Fix: PHP undefined notice in caching file storage

[zero-24]

see: http://issues.joomla.org/tracker/joomla-cms/2535 & #2535

Steps to reproduce the issue

1. configure caching to be file based in configuration.php
2. use callback as handler
3. lock the id
4. remove the cache file
5. unlock the id now

Expected result

If the cache file has beem removed, the unlock should just return true.

Actual result

Get php undefined variable notice:
Notice: Undefined variable: ret in web/libraries/joomla/cache/storage/file.php on line 333

System information (as much as possible)

Linux, Joomla 3.2 latest.

[zero-24]

hmm i have no clue why travis fail here?

There were 4 errors:
1) JResponseJsonTest::testSimpleSuccess
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:59
2) JResponseJsonTest::testSuccessWithData
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:79
3) JResponseJsonTest::testFailureWithException
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:100
4) JResponseJsonTest::testFailureWithData
Exception: Application Instantiation Error
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:121
/home/travis/build/joomla/joomla-cms/libraries/cms/response/json.php:71
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/response/JResponseJsonTest.php:124

[mbabker]

Don't worry about it, already addressed. Refactored tests and a modified application reference in two separate patches at nearly the exact time made for an interesting followup.

[zero-24]

thanks @mbabker

[Hackwar]

@test successfull

[waader]

@zero-24 I tried to follow the test instructions but I struggle already at the 2nd point. How do I use callback as handler. Do I have to write code to test this or can it be tested within the backend?