Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :: Component view is not responsive in protostar #4764 #4768

Closed
wants to merge 1 commit into from

Conversation

rbsl-rakesh
Copy link
Contributor

Viewport meta tag in has been added in component view of template protostar.

to see this you will need to add ?tmpl=component to the URL

@superfoght
Copy link

Works for me on Android and IOS. Don't have a Windows phone to test on :(

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4768.

@brianteeman
Copy link
Contributor

why are you adding this. Bootstrap does it itself iirc - anyway I am seeing your proposed change already in my protostar test site

screen shot 2014-10-17 at 07 08 26

@superfoght
Copy link

When I add ?tmpl=component to the URL, that meta is not there for me: http://screencast.com/t/slkak3vZ - it's correct it's there in the template without adding ?tmpl=component



This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4768.

@brianteeman
Copy link
Contributor

Ah - sorry bo - quite correct it does say component view i didnt think that meant ?tmpl=component

It is a bug indeed - setting back to pending for testing and updating the original post with your comments


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4768.

@brianteeman
Copy link
Contributor

Thanks for the code and thanks for the tests

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4768.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants