Batch process pop-up gets open even without selection

[garima-agal]

. We can apply validation, to make selection first

[peterlose]

Works fine. Perhaps we should take it a step further at hide the batch button until something is selected?

[brianteeman]

@losedk the UX sprint last year tried to get that sort of change in and it was rejected. :(

On the basis of two good tests I am setting this RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4787.

[peterlose]

@brianteeman ahh okay :S

[zero-24]

@garima-agal It looks like we have a failed Travis test:

There was 1 failure:
1) JToolbarButtonHelpTest::testFetchButton
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<button onclick="Joomla.popupWindow('help/en-GB/JHELP_CONTENT_ARTICLE_MANAGER.html', 'JHELP', 700, 500, 1)" rel="help" class="btn btn-small">
+'<button onclick="Joomla.popupWindow('help/en-GB/Content_Article_Manager.html', 'Help', 700, 500, 1)" rel="help" class="btn btn-small">
    <span class="icon-question-sign"></span>
-   JTOOLBAR_HELP</button>
+   Help</button>
 '
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/toolbar/button/JToolbarButtonHelpTest.php:102

See: https://travis-ci.org/joomla/joomla-cms/jobs/38266232

Can you have a look into it?

[Bakual]

Merged, thanks.
After some tests in my fork I came to the conclusion that the failed tests must be due to some outdated branch and not related to the PR.

[infograf768]

FYI, just corrected this
de6b74a