Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email cloaking kills email value of input field #5080

Closed
schmidt1024 opened this issue Nov 10, 2014 · 8 comments
Closed

email cloaking kills email value of input field #5080

schmidt1024 opened this issue Nov 10, 2014 · 8 comments

Comments

@schmidt1024
Copy link

Steps to reproduce the issue

The plugin kills the email value of an input field, when ohter inputs of the form don't validate.

<input value="" size="20" name="form[EMail]" id="EMail" class="rsform-input-box" type="text">

Expected result

<input value="mail@example.com" size="20" name="form[EMail]" id="EMail" class="rsform-input-box" type="text">

Actual result

<input value="<span id=" cloak45076"="" type="text">

System information (as much as possible)

Joomla 3.3.6
E-Mail Cloaking enabled

@spignataro
Copy link
Contributor

For your content pages you can run the following to disable the email cloaking: {emailcloak=off}


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5080.

@roland-d
Copy link
Contributor

roland-d commented Sep 5, 2015

Hello @Bloggerschmidt,

Thank you for your contribution.

The last comment here was on 20 July 2015. So the question is, Is this issue/pull request still valid?
If no reply is received within 4 weeks we will close this issue.

In case the issue still exists, can you please provide clearer step-by-step instructions.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5080.

@spignataro
Copy link
Contributor

The issue is still valid. I am not a regular expression person to solve this. It needs to check to see if the email is within a input field as a value.

@dgrammatiko
Copy link
Contributor

It needs to check to see if the email is within a input field as a value.

@spignataro this doesn’t sound quite correct, cloaking is supposed to check in the content area.
Input fields are not quite used there and should be part of a form. Also input fields use the javascript validation and the server side validation for an email input. I would say that this is a very odd use case.

@spignataro
Copy link
Contributor

I would have to disagree. I have many clients whom put in forms on their content pages. I have stopped putting in anything in the value field because of this bug. It just needs to check to see if the value has a email address and if it does just skip over the cloaking.

@roland-d
Copy link
Contributor

@spignataro As this isssue has no code attached, can you provide a way to reproduce this issue, we can then look at adding the needed code.

@spignataro
Copy link
Contributor

Put in code into the input area:

<input value="mail@example.com" size="20" name="form[EMail]" id="EMail" class="rsform-input-box" type="text">

with the plugin turned on take a look at the marketup.

@zero-24
Copy link
Contributor

zero-24 commented Oct 9, 2015

here is a PR for that issue: #8039

@zero-24 zero-24 closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants