Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce jquery formvalidator for com_content ::frontend #5113

Closed
wants to merge 2 commits into from
Closed

Introduce jquery formvalidator for com_content ::frontend #5113

wants to merge 2 commits into from

Conversation

dgrammatiko
Copy link
Contributor

Executive summary

This PR converts the form validation on com_content to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!

Testing

  1. Apply first PR Reduce unneeded calls for mootools #4888 (!important)
  2. Apply this PR
  3. In the admin area create new menu item for submitting new article
  4. go to the new menu and test that article is saved correctly

If no javascript errors are logged in your browser’s console and the functionality remains the same, your test is passing in any other case please report the errors here

Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
Logout and log in to demonstrate the use of noframes without mt.

@smanzi
Copy link

smanzi commented Nov 16, 2014

@test success

@dgt41 tooltips misaligned, but I seems to remember you said this is expected... Can you confirm?

@dgrammatiko
Copy link
Contributor Author

@smanzi Yes Sergio, this is unrelated (try some browser cache clearing)

@Hackwar
Copy link
Member

Hackwar commented Nov 17, 2014

@test success
I can equally report that everything works except for the misaligned tooltips.

@Hackwar
Copy link
Member

Hackwar commented Nov 17, 2014

I did clear my browser cache and it did not go away. The tooltips are still misaligned.

@dgrammatiko
Copy link
Contributor Author

@smanzi @Hackwar Actually you are both right here, the tooltip is misaligned. But this has to do with the bootstrap css on protostar, not with jquery code. I’ll try to propose a solution

screen shot 2014-11-17 at 12 15 04
screen shot 2014-11-17 at 12 15 19

@dgrammatiko dgrammatiko mentioned this pull request Nov 17, 2014
@roland-d
Copy link
Contributor

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5113.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Nov 29, 2014
@smanzi
Copy link

smanzi commented Nov 30, 2014

@test success for this PR (created new article in front-end, no prob!)
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

@dgrammatiko dgrammatiko deleted the _form_jq_com_content_frontend branch December 1, 2014 18:48
@Bakual Bakual added this to the Joomla! 3.4.0 milestone Dec 2, 2014
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants