Don't change the default session_handler if it is allready set Ref: #5127

[zero-24]

Steps to reproduce the issue

We are using memcache as default session handler and this set up is in php.ini.

Expected result

Joomla to use default session handler is not set in configuration.

Actual result

PHP Warning: session_start(): open(tcp://127.0.0.1:11211/sess_r5c5940ecaru55pr69bssctmu2, O_RDWR) failed: No such file or directory

System information (as much as possible)

php.ini: session.save_handler = memcache

Additional comments

Change libraries/joomla/session/storage/none.php to use default php session handler.

See: #5127 by @Olvikolvi

[zero-24]

tested by @Olvikolvi at #5127

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5142.

[Fedik]

found old one #2695, that can be closed after current will be merged

[Fedik]

looks like here the mistake,
by call if ($handler = '') you reset $handler variable to empty value, so it always false
I think just enough if(!ini_get('session.save_handler'))

[zero-24]

Thanks @Fedik fixed with: 7e751e1

[Fedik]

@zero-24 still small mistake ;)

also I just thought, maybe also can remove this construction, as default PHP 'session.save_handler' is 'files'

[zero-24]

done @Fedik

[Fedik]

@zero-24 thanks!

test
works good

[zero-24]

Based on testing and a other PR that is tested and that whant to add the same code we can move this to RTC.

Thanks for testing here @Fedik and @Olvikolvi !

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5142.}

[oparoz]

👍

[phproberto]

Merged. Thanks!