[J25] Fix: Installation error: Deprecated: iconv_set_encoding(): Use of iconv.output_encoding is deprecated

[zero-24]

This fixes: #5192

See 82d8459 for the fix against staging.

Steps to reproduce the issue

Download and extract xampp 5.6.3 (they change the versioning to reflect the PHP Version)
Download and extract joomla 2.5.x (github branche or stable)
try to install

Expected result

Install works (after fixing this it still don't work but i will open a new issue for that; see: #5193 )

Actual result

Deprecated: iconv_set_encoding(): Use of iconv.internal_encoding is deprecated in JRoot\libraries\joomla\string\string.php on line 28
Deprecated: iconv_set_encoding(): Use of iconv.input_encoding is deprecated in JRoot\libraries\joomla\string\string.php on line 29
Deprecated: iconv_set_encoding(): Use of iconv.output_encoding is deprecated in JRoot\libraries\joomla\string\string.php on line 30

System information (as much as possible)

Default xampp Konfiguration with:

Apache 2.4.10, MySQL 5.6.21, PHP 5.6.3, phpMyAdmin 4.2.11, OpenSSL 1.0.1, XAMPP Control Panel 3.2.1, Webalizer 2.23-04, Mercury Mail Transport System 4.63, FileZilla FTP Server 0.9.41, Tomcat 7.0.56 (with mod_proxy_ajp as connector), Strawberry Perl 7.0.56 Portable

Additional comments

I think the Joomla Core should work with the default xampp config as it is often used for "testing" and planing joomla if can't be done on the production site not only by experts mostly by end users to pre-test Joomla.

[infograf768]

Should not
+if (version_compare(PHP_VERSION, '5.6', '>='))
be INSIDE the
if (function_exists('iconv') || ((!strtoupper(substr(PHP_OS, 0, 3)) === 'WIN' && dl('iconv.so'))))
conditional?

[infograf768]

see /libraries/vendor/joomla/string/src/String.php

[zero-24]

done @infograf768 zero-24@026bc19

[infograf768]

I would keep the original conditional
if (function_exists('iconv') || ((!strtoupper(substr(PHP_OS, 0, 3)) === 'WIN' && dl('iconv.so'))))

What you think?

[Bakual]

I think the Joomla Core should work with the default xampp config as it is often used for "testing" and planing joomla if can't be done on the production site not only by experts mostly by end users to pre-test Joomla.

To be blunt, I don't expect many testing being done on 2.5 anymore. Last release is only a week or two away. 😄

[zero-24]

I would keep the original conditional

fixed @infograf768 zero-24@7023efb

[infograf768]

Does not cost much to get in. ☺ Merging. Thanks.