Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in "Smart Search" (com_finder) #5204

Closed
smanzi opened this issue Nov 25, 2014 · 5 comments
Closed

Issues in "Smart Search" (com_finder) #5204

smanzi opened this issue Nov 25, 2014 · 5 comments

Comments

@smanzi
Copy link

smanzi commented Nov 25, 2014

There are two issues in "Smart Search" that are lingering since some time and should be solved:

  1. In a multilingual environment content flagged for "All" languages is searched (indexed) only for the default language
  2. Search terms found inside some tags (e.g.: <h1>) are suggested (indexed too?) out of context and with other terms appended (without space)

@chrisdavenport suggests that issue n.2 is probably due to errors in HTML parsing

In the next post I'll attach screenshots demonstrating the above issues. Keep in mind that this is done in a multilingual environment (English/Italiano) and that there are two articles for each of the two languages plus an article shared amongst the two (language = "All"). The search term "pancetta" appears in all five articles.

@smanzi
Copy link
Author

smanzi commented Nov 25, 2014

I forgot to mention that the search term "pancetta" is suggested by itself only for the (non-default) it-IT language (and this is probably a third issue...)

Screenshots:

english-suggestions
english-results
italiano-suggestions
italiano-results
bad-suggestions

@smanzi
Copy link
Author

smanzi commented Nov 25, 2014

For the second issue I created PR #5206

@waader
Copy link
Contributor

waader commented Nov 27, 2014

Can this be marked as RTC or does it need further testing?

@smanzi
Copy link
Author

smanzi commented Nov 27, 2014

@waader this is just the "issues" entry: the PR fixing (part of) this is #5206 which currently has no tests and thus will not be RTC. If you wish you can give an @test at that PR, but keep in mind that we will probably see a more proper fix by @chrisdavenport.

@smanzi
Copy link
Author

smanzi commented Dec 8, 2014

As many of the issues described here are addressed by #5340 (thanks @chrisdavenport) I'm closing this an opening a new one specific for the multilingual search issue.

Thanks to everybody!

New issue is #5352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants