Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two more index.html found #5467

Merged
merged 1 commit into from
Dec 18, 2014
Merged

Two more index.html found #5467

merged 1 commit into from
Dec 18, 2014

Conversation

smz
Copy link
Contributor

@smz smz commented Dec 18, 2014

Should we expel those two rascals?

Should we expel those two rascals?
Bakual pushed a commit that referenced this pull request Dec 18, 2014
@Bakual Bakual merged commit c79aee9 into joomla:staging Dec 18, 2014
@smz smz deleted the TwoMoreIndexHTML branch December 18, 2014 19:33
@shur
Copy link
Contributor

shur commented Dec 19, 2014

Perhaps we can even remove these 2 files:
/administrator/templates/hathor/html/com_finder/filter/index.html
/administrator/templates/hathor/html/com_finder/statistics/index.html

Since these directories do not contain anything (except index.html), they can be removed too:
/administrator/templates/hathor/html/com_finder/filter/
/administrator/templates/hathor/html/com_finder/statistics/

@smz
Copy link
Contributor Author

smz commented Dec 19, 2014

@shur I think (but I'm unsure) those two directories are needed in case you create filters and/or gather statistics...

@brianteeman
Copy link
Contributor

unlikely as those are template overrides

@smz
Copy link
Contributor Author

smz commented Dec 19, 2014

@brianteeman correct!
@shur this PR has already been merged: do you want to make a new one?

@shur
Copy link
Contributor

shur commented Dec 19, 2014

@snz since these folders are empty, they are not involved in template overrides. So they can be deleted.

do you want to make a new one?

No, I don't. It's up to you.

@smz
Copy link
Contributor Author

smz commented Dec 19, 2014

OK!

@smz
Copy link
Contributor Author

smz commented Dec 19, 2014

Done in #5471

@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants