Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset reference variable after looping by reference for administrator/modules/mod_[a-z] and hathor admin templates #5495

Closed
wants to merge 8 commits into from

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Dec 23, 2014

  • When looping by reference, reference variable is not unset at the end of the loop.
  • and a bit CodeStyle

see: #5482

@waader
Copy link
Contributor

waader commented Jan 27, 2015

@zero-24 Is this something to test or does it need review by PLT?

@zero-24
Copy link
Contributor Author

zero-24 commented Jan 27, 2015

Thanks @waader no we can't test this. And it is no bug it is more a bad practice.

@ggppdk (at: #5482 (comment)):

Again this is not a bug, just a very dangerous practice not to unset the variable that references the array of the loop.

or does it need review by PLT?

Yes it needs only a decision / review by the PLT to remove this bad practice or not. So nothing to test here. Thanks! 😄

@zero-24
Copy link
Contributor Author

zero-24 commented Mar 19, 2015

Closing since we have no response since 23 Dec 2014


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5495.

@zero-24 zero-24 closed this Mar 19, 2015
@zero-24 zero-24 deleted the patch-23 branch March 19, 2015 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants