Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Debug Permissions Report don't work correct on Joomla 3.x (Fix #4117) #5841

Merged
merged 5 commits into from
Jan 21, 2015
Merged

The Debug Permissions Report don't work correct on Joomla 3.x (Fix #4117) #5841

merged 5 commits into from
Jan 21, 2015

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jan 21, 2015

See #4117 for full background

Test instructions (from original issue)

  1. Install J3
  2. Enable debug on J3
  3. Go to Backend --> Users --> User Manager --> Debug Permissions Report
  4. See what is there; Something like:

screen shot 2014-08-15 at 04 34 34

  1. Apply patch
  2. Result should look like this:

screen shot 2015-01-20 at 8 47 37 pm

@brianteeman
Copy link
Contributor

@test perfection - thanks

I was close but no cigar


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5841.

@dgrammatiko
Copy link
Contributor

@test success
@mbabker can you add a class table-condensed to the table? Corrects the width..
screen shot 2015-01-21 at 4 02 34

@dgrammatiko
Copy link
Contributor

@mbabker see

@brianteeman
Copy link
Contributor

Might be better to simply remove the class =nowrap from the titles
It will look better then as well as all the columns should be the same width

On 21 January 2015 at 02:07, Dimitris Grammatiko notifications@github.com
wrote:

@mbabker https://github.com/mbabker see
https://github.com/mbabker/joomla-cms/pull/21


Reply to this email directly or view it on GitHub
#5841 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Dimitris Grammatiko and others added 2 commits January 21, 2015 04:18
@dgrammatiko
Copy link
Contributor

@mbabker also a PR for removal of class nowrap here

table-condensed and nowrap preview
screen shot 2015-01-21 at 4 20 27

@zero-24
Copy link
Contributor

zero-24 commented Jan 21, 2015

May thanks @mbabker! @test success --> Moving to RTC

For the select boxes on the sidebar i will open a new PR so we can merge this here! Thanks for testing an coding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5841.

rdeutz added a commit that referenced this pull request Jan 21, 2015
The Debug Permissions Report don't work correct on Joomla 3.x (Fix #4117)

Thanks all :-)
@rdeutz rdeutz merged commit 239d5cf into joomla:staging Jan 21, 2015
@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Jan 21, 2015
@mbabker mbabker deleted the userdebug branch January 21, 2015 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants