Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons on IE 10 throwing JS error??? #5901

Closed
ericfernance opened this issue Jan 28, 2015 · 10 comments
Closed

Toolbar buttons on IE 10 throwing JS error??? #5901

ericfernance opened this issue Jan 28, 2015 · 10 comments

Comments

@ericfernance
Copy link
Contributor

Steps to reproduce the issue

Not sure if this is just me or if others are getting the same thing.

Using the beta of 3.4 from github on a Windows 7 - IE 10 VM. Go to Article Manager and click new.

It should go to a new article but on IE 10 it appears to be throwing a JS error.

screen shot 2015-01-28 at 02 27 22

Other versions seem unaffected.

Expected result

Expected result would be opening a new article in Article Manager

Actual result

Actual result is a JS error and nothing happens.

System information (as much as possible)

Latest J3.4 download from Github.

Additional comments

@peterlose
Copy link
Contributor

Confirmed

@Fedik
Copy link
Member

Fedik commented Jan 28, 2015

looks like problem with fireEvent ..
before it was by mootools, and as there no mootools anymore, IE use native one,

just a quick guess ... unfortunately, curently I have no IE for check this theory

@Bakual
Copy link
Contributor

Bakual commented Jan 28, 2015

Tracked it down to commit 68b58f3 (PR #4888)

Something for @dgt41 to look at.

@dgrammatiko
Copy link
Contributor

@Bakual from a quick search I think this is more related to core.js
http://stackoverflow.com/questions/17720431/javascript-dispatchevent-is-not-working-in-ie9-and-ie10

I'll try to post a more descriptive answer and maybe a pr later on when I'll get back to my desk

@Bakual
Copy link
Contributor

Bakual commented Jan 28, 2015

I think the comment from Fedik is correct. fireEvent previously was provided by MooTools, it then broke because MooTools is no longer there due to your PR.

If you can do a PR to fix this, that would be awesome!

What I find disturbing is that apparently nobody tested creating any item on IE10 since about 2 months, including an alpha release. 😞

@dgrammatiko
Copy link
Contributor

This was the solution mootools used back to 2010:
http://jsbin.com/uvesu3/8/edit?js,output
Here is the talk:
https://mootools.lighthouseapp.com/projects/2706/tickets/976-resolve-fireevent-issues-with-ie9

This is the proposed code:

    if (typeof HTMLElement != 'undefined') {
        HTMLElement.prototype.fireEvent = Element.prototype.fireEvent;
    }

After line 31 in core-uncompressed.js
The only problem I don’t have IE9 to test it 😕
@digitalgarage can you try this code with IE9?

@Fedik
Copy link
Member

Fedik commented Jan 28, 2015

please test #5914

@jissues-bot
Copy link

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/5901

@zero-24
Copy link
Contributor

zero-24 commented Jan 28, 2015

Closing as we have a PR by @Fedik Thanks! #5914


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5901.

@dgrammatiko
Copy link
Contributor

@Fedik thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants