Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing one superfluous language string #5932

Merged
merged 1 commit into from Jan 30, 2015

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jan 30, 2015

With #4171 we introduced a new postinstall message about the changed htaccess.txt and web.config.txt files.
That PR added a language string which isn't needed because we don't have an action assigned to that message. Thus there is no button to press beside the default "Hide Message".

This PR removes that string so translators don't have to translate it.
Since the string is not yet in a stable release (only in alpha and beta) we can still remove it without any backward compatibility issues.

@infograf768 Agree?

@brianteeman
Copy link
Contributor

As you are removing the code that would display the string it can not be an
issue even if it is translated

On 30 January 2015 at 14:39, Thomas Hunziker notifications@github.com
wrote:

With #4171 #4171 we introduced
a new postinstall message about the changed htaccess.txt and web.config.txt
files.
This PR added a language string which isn't needed because we don't have
an action assigned to that message. Thus there is no button to press beside
the default "Hide Message".

This PR removes that string so translators don't have to translate it.
Since the string is not yet in a stable release (only in alpha and beta)
we can still remove it without any backward compatibility issues.

@infograf768 https://github.com/infograf768 Agree?

You can view, comment on, or merge this pull request online at:

#5932
Commit Summary

  • Removing superfluous language string.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#5932.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@rdeutz
Copy link
Contributor

rdeutz commented Jan 30, 2015

Looks good to me

@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Jan 30, 2015
rdeutz added a commit that referenced this pull request Jan 30, 2015
Removing one superfluous language string
@rdeutz rdeutz merged commit 50842e9 into joomla:staging Jan 30, 2015
@Bakual Bakual deleted the RemoveUnusedLangKey branch January 30, 2015 18:42
@waader
Copy link
Contributor

waader commented Jan 30, 2015

@test works for me - mysql, postgresql, mssql

@infograf768
Copy link
Member

I found that issue when translating. Will let TTs know that string is no use anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants