Cleaning up the checks in Modules renderer for performance

[Hackwar]

See #5996. This shuffles around the checks in the modules renderer to bail out as soon as possible for the module editing. The only functional change is, that module editing with this requires that the user is logged in regardless of the permissions set. The situation that an unauthenticated user is allowed to edit modules in the frontend, is VERY uncommon.

How to test

• Install current staging
• See times of beforeRenderModule module in debugging
• Apply patch
• See times have cut down to about a tenth of the original value

Make sure that you are not logged in when doing this. There should be no change in performance if the user is logged in.

[brianteeman]

@test MASSIVE improvement thanks

before

after

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6032.}

[brianteeman]

Hit post too early. As you can see there are no duplicate queries now. So the queries take 3 second less

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6032.}

[dgrammatiko]

@test ok. I also agree to set front end editing default value to disabled

Multilingual (en, gr) default install data
Before:

After:

[infograf768]

@test
Done on my multilingual test site, home page default site language:
Guest
Before 6032:

After 6032

After but LOGGED as REGISTERED USER:

After but LOGGED as REGISTERED USER after switching to French Home page:

After logging out on same French Home page:

Switching to Italian Home page (still as guest)

Switching to German Home page (still as guest)

Switching to French Home page (still as guest)

NOTE: French has more menu items (+11) and one more module (Archived)

[zero-24]

Thanks @Hackwar i can't do more than move to RTC! Thanks for coding and testing here!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6032.}

[wilsonge]

Merged. Thankyou very much Hannes!