Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed JCrop in Template Manager #6214

Merged
merged 1 commit into from
Feb 27, 2015
Merged

fixed JCrop in Template Manager #6214

merged 1 commit into from
Feb 27, 2015

Conversation

C-Lodder
Copy link
Member

Cropping images in the Template Manager did not appear to be working and was reported on JSE today

http://joomla.stackexchange.com/questions/8805/using-jquery-jcrop-js-in-custom-extension/8806#8806

It was throwing a console log error:

SyntaxError: missing : after property id

trueSize: 469,159

Also added $ as an alias to prevent objects being undefined.

@wilsonge
Copy link
Contributor

Bug introduced by #5054

@zero-24
Copy link
Contributor

zero-24 commented Feb 27, 2015

@test successful. It fix the issue for me. Thanks @C-Lodder


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6214.

@peterlose
Copy link
Contributor

Tested. Solves the problem

@zero-24
Copy link
Contributor

zero-24 commented Feb 27, 2015

Thanks for the fix and tests moving to RTC here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6214.

wilsonge added a commit that referenced this pull request Feb 27, 2015
fixed JCrop in Template Manager
@wilsonge wilsonge merged commit 7a32c81 into joomla:staging Feb 27, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.1 milestone Feb 27, 2015
@dgrammatiko
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants