Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en-GB.com_postinstall.ini (cosmetic) #6215

Merged
merged 3 commits into from Mar 22, 2015
Merged

Update en-GB.com_postinstall.ini (cosmetic) #6215

merged 3 commits into from Mar 22, 2015

Conversation

Hils
Copy link
Contributor

@Hils Hils commented Feb 27, 2015

(from Joomla.org) - Joomla.org is not a word or a link or a location. Should it be linked somewhere? Should it be to Joomla's home page? (http://www.joomla.org/) or perhaps the correct category in docs? Joomla.org is the slang term we all use and we know what it means ;)

@zero-24
Copy link
Contributor

zero-24 commented Feb 27, 2015

@Hils do you think we can use: <a href="_QQ_"http://www.joomla.org"_QQ_">http://www.joomla.org/</a>

@zero-24
Copy link
Contributor

zero-24 commented Feb 27, 2015

or @Hils
<a href="_QQ_"http://www.joomla.org/announcements/release-news/"_QQ_">from joomla.org</a>

@Hils
Copy link
Contributor Author

Hils commented Feb 27, 2015

COM_POSTINSTALL_LBL_RELEASENEWS="<a href="QQ"http://www.joomla.org/announcements/release-news/"_QQ_">from the Joomla! Project" (project word 'stolen' from marketing on 3.4.0 release page ;) ) - is that OK?

@zero-24
Copy link
Contributor

zero-24 commented Feb 27, 2015

just to be sure:
COM_POSTINSTALL_LBL_RELEASENEWS="Release news <a href="_QQ_"http://www.joomla.org/announcements/release-news/"_QQ_">from the Joomla! Project</a>"

looks good here 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6215.

@brianteeman
Copy link
Contributor

For future reference of anyone else seeing this

The rule of thumb for usage of the ! is
Whenever you can substitute "your Joomla CMS" in place of "Joomla" and still make sense, then it's descriptive and no bang needed.

As for making this a link - is it really necessary - it is a title and everything below the title is a link in iteself

@Hils
Copy link
Contributor Author

Hils commented Feb 27, 2015

Perhaps it is best to quote this in comments:
joomla/user-interface-text@1b384a2
that is what I am working from

@brianteeman
Copy link
Contributor

that is the exact quote i used unless my eyesight is failing and copy/paste is not working

Update en-GB.com_postinstall.ini
@Hils
Copy link
Contributor Author

Hils commented Feb 27, 2015

Your eyesight is working perfectly but now everyone has the full information and the location where they can find it in future.

@brianteeman
Copy link
Contributor

I deliberately did NOT link to a specific location as that location is not
permanent

On 27 February 2015 at 13:58, Hils notifications@github.com wrote:

Your eyesight is working perfectly but now everyone has the full
information and the location where they can find it in future.


Reply to this email directly or view it on GitHub
#6215 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Hils
Copy link
Contributor Author

Hils commented Feb 27, 2015

Apologies - @ALL please ignore that link to the bang rules provided by @Duke3D

@Hils Hils changed the title Update en-GB.com_postinstall.ini (cosmetic) & check line 13 please Update en-GB.com_postinstall.ini (cosmetic) Feb 27, 2015
@dnimooj
Copy link

dnimooj commented Mar 14, 2015

works


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6215.

@zero-24
Copy link
Contributor

zero-24 commented Mar 14, 2015

RTC based on testing Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6215.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Mar 14, 2015
@infograf768
Copy link
Member

To merge after 3.4.1

@phproberto phproberto added this to the Joomla! 3.4.2 milestone Mar 15, 2015
wilsonge added a commit that referenced this pull request Mar 22, 2015
Update en-GB.com_postinstall.ini (cosmetic)
@wilsonge wilsonge merged commit e5dfc6e into joomla:staging Mar 22, 2015
@wilsonge
Copy link
Contributor

Thanks Hils :)

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants