Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL commands for sample and testing data #6241

Closed
wants to merge 2 commits into from

Conversation

Erftralle
Copy link
Contributor

This is a fix for issue #6216. Please read #6216 for further informations and test instructions.

@stellainformatica
Copy link
Contributor

@test
Patch tested with sample_data.sql

It works as expected, thanks Erftralle

@waader
Copy link
Contributor

waader commented Mar 2, 2015

@test works with sample_testing.sql! Thanks!

@zero-24
Copy link
Contributor

zero-24 commented Mar 2, 2015

Moving to RTC based on testing. Thanks! For coding and testing!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6241.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Mar 2, 2015
@alikon
Copy link
Contributor

alikon commented Mar 5, 2015

it seems that lacks the corresponding changes on postgresql and mssql sample files

@Erftralle
Copy link
Contributor Author

it seems that lacks the corresponding changes on postgresql and mssql sample files

Done!
Unfortunately I can not test it myself.

@alikon
Copy link
Contributor

alikon commented Mar 5, 2015

You should do the same on sample_data too

@Erftralle
Copy link
Contributor Author

You should do the same on sample_data too

Sorry, but I don't know what you want me to do.

The sample_data.sql for MySQL is ok for me, in the related files for PostgreSQL and SQL Azure there is nothing to do regarding the Tags table.

Maybe I missed something. Can you point me into the right direction.

@alikon
Copy link
Contributor

alikon commented Mar 5, 2015

No sir you are right 👌

@waader
Copy link
Contributor

waader commented Mar 5, 2015

@test success with postgresql and mssql! Thanks!

@phproberto phproberto closed this in 6838482 Mar 7, 2015
@phproberto
Copy link
Contributor

Merged thanks!

@roland-d roland-d added this to the Joomla! 3.4.1 milestone Mar 7, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@Erftralle Erftralle deleted the fix-sql-sample-data branch August 15, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants