Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing media.less is missing in Isis template #6417

Closed
wants to merge 1 commit into from
Closed

importing media.less is missing in Isis template #6417

wants to merge 1 commit into from

Conversation

hans2103
Copy link
Contributor

Bootstrap 2.3.2 default available file called media.less is missing in Isis template.
http://getbootstrap.com/2.3.2/components.html#media

example of use for this css output: when using an image in the description of an installed extension and you want to outline large text next to the image.

Bootstrap 2.3.2 default available file called media.less is missing in Isis template. 
http://getbootstrap.com/2.3.2/components.html#media

example of use for this css output: when using an image in the description of an installed extension and you want to outline large text  next to the image.
@hans2103 hans2103 changed the title importing media.less is missing importing media.less is missing in Isis template Mar 13, 2015
@gorgonz
Copy link

gorgonz commented Mar 14, 2015

Verified it in the templates.less of isis and saw the results in template.css - after compiling

@Bakual
Copy link
Contributor

Bakual commented Mar 14, 2015

@hans2103 Can you try running the file /build/generatecss.php from your CLI?
That would generate the template.css file for the Isis template and it could be tested better.

@schmidt1024
Copy link

error on compiling template.less by /build/generatecss.php

expected color value: failed at ../media/jui/less/accordion.less";
C:\xampp\htdocs\pbf\administrator\templates\isis\less/template.less on line 48
expected color value: failed at 16.5%
C:\xampp\htdocs\pbf\administrator\templates\isis\less/template-rtl.less on line 100


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6417.

@jessicadunbar
Copy link

Compiled less in the isis templates.less - success after viewing source of template.css


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6417.

@gorgonz
Copy link

gorgonz commented Mar 15, 2015

  1. try, more exactly now:
    before:
  2. media.less attribute ".media .media" not existing in template.css of isis
  3. compiling in the template and with help of generatecss.php did not change anything

after patch:

@hans2103
Copy link
Contributor Author

@Bakual
just run "php buil/generatecss.php" from CLI
the result is not what I expexted. See comparison below.
staging...hans2103:staging

I was expecting to see new css lines in template.css from isis template.
I notice an import of media.less in template.css

@hans2103
Copy link
Contributor Author

moment... I see what went wrong... typo main.less should be media.less. Oops

@hans2103
Copy link
Contributor Author

This PR can be closed since I've made a new Pull Request #6465 containing changed less and compiled .css files.
Thank you @Bakual for explaining me how to compile from CLI in your comment above. Didn't knew that was possible to do.
#6465

@hans2103 hans2103 closed this Mar 16, 2015
wilsonge added a commit that referenced this pull request Mar 25, 2015
importing media.less is missing in Isis template - replaces PR #6417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants