Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for attribute maxlength. Form field textarea. Issue #6459 #6460

Closed
wants to merge 2 commits into from
Closed

Support for attribute maxlength. Form field textarea. Issue #6459 #6460

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2015

Issue #6459

The maxlength attribute specifies the maximum length (in characters) of a text area. The maxlength attribute is new for the < textarea > tag in HTML5.

Test:

  • Edit /administrator/components/com_config/model/form/application.xml
  • Add attribute
    maxlength="25"
    to field MetaDesc (or any other field of type textarea).
  • Go to administrator/index.php?option=com_config > Site
  • Enter text into field "Site Meta Description".
  • No limitation concerning length.
  • Apply patch. Try again. 25 characters maximum are possible.

Issue #6459

The maxlength attribute specifies the maximum length (in characters) of a text area. The maxlength attribute is new for the <textarea> tag in HTML5.

Test:

- Edit /administrator/components/com_config/model/form/application.xml
- Add attribute
maxlength="25"
to field MetaDesc (or any other field of type textarea).
- Go to administrator/index.php?option=com_config > Site
- Enter text into field "Site Meta Description".
- No limitation concerning length.
- Apply patch. Try again. 25 characters maximum are possible.
@fruppel
Copy link

fruppel commented Mar 16, 2015

@test successful

Tested in all major browsers.
Thank you :-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6460.

@n9iels
Copy link
Contributor

n9iels commented Mar 21, 2015

@test works fine for me, thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6460.

@zero-24
Copy link
Contributor

zero-24 commented Apr 1, 2015

RTC! Thanks to all here!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6460.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Apr 1, 2015
@phproberto phproberto added this to the Joomla! 3.5.0 milestone Apr 6, 2015
@wilsonge wilsonge closed this in 550ca2e May 25, 2015
@wilsonge
Copy link
Contributor

Merged into staging

@wilsonge wilsonge modified the milestones: Joomla! 3.4.2, Joomla! 3.5.0 May 25, 2015
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants