Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow toolbar popup buttons use bootstrap footer #6462

Closed
wants to merge 5 commits into from
Closed

Allow toolbar popup buttons use bootstrap footer #6462

wants to merge 5 commits into from

Conversation

dgrammatiko
Copy link
Contributor

Allow custom footer on BS modals rendered from toolbar button

This is a new feature requested at #4563

What it does?

Allows to render modal in the bootstrap official way, where the buttons are on the bottom of the modal window

How to test

Apply this patch and #4563
Change line 83 of administrator/components/com_messages/views/messages/view.html.php to

$bar->appendButton('Popup', 'cog', 'COM_MESSAGES_TOOLBAR_MY_SETTINGS', 'index.php?option=com_messages&amp;view=config&amp;tmpl=component', 600, 250, 0, 0, '', '', '<a href="#" class="btn">Close</a> <a href="#" class="btn btn-primary">Save changes</a>');

You should get:
screen shot 2015-03-16 at 8 10 49

Mind that the buttons are fake, no functionality is attached

@n9iels
Copy link
Contributor

n9iels commented Mar 16, 2015

@test Looks good on desktop, on mobile layout the buttons fall over each other

@peterlose
Copy link
Contributor

Just tested it. It works fine!

@peterlose
Copy link
Contributor

Should we move this RTC? Two good tests

@dgrammatiko
Copy link
Contributor Author

@zero-24 can we RTC this one?

@zero-24
Copy link
Contributor

zero-24 commented May 25, 2015

Thanks for the bump 😄 RTC now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6462.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 25, 2015
@zero-24
Copy link
Contributor

zero-24 commented May 25, 2015

@committer please be sure that #4563 is merged bevor this as this is a requirement.

@wilsonge wilsonge closed this in a6f8dbf May 28, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.2 milestone May 29, 2015
@dgrammatiko dgrammatiko deleted the _bs_footer_for_toolbar_btn branch May 31, 2015 08:19
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants