Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout login view (redo of #6432) #6535

Merged
merged 2 commits into from
Mar 26, 2015
Merged

Update layout login view (redo of #6432) #6535

merged 2 commits into from
Mar 26, 2015

Conversation

n9iels
Copy link
Contributor

@n9iels n9iels commented Mar 22, 2015

This is a redo of #6432 because of merge conflicts.
Please see that one for test instructions


The problem

I discovered that the alignment on the login page of isis is not 100% pixel perfect. The field are just a few pixels to width. Hower, on RTL languages the wrong alignment was very good visible. So this patch solves alignment problems on LTR and RTL languages. I also add the possibility to load the templates-rtl.css in the login-view.
Farther optimizations:

  • font-set icon icon-joomla instead of .png icon for the Joomla! logo on bottom of the loginform
  • Full width login button

Before/after screenshots

LTR before
lrt-before

LTR after (very small difference on the right of the fields)
ltr after

RTL before
rtl before

RTL after
rtl after

How to test this patch

  1. Confirm the before/after screenshots on a LTR language (English)
  2. Confirm 100% page width button and sharp Joomla! logo on bottom
  3. Change your language to a RTL language (Persion for example)
  4. Test step 2 and 3 again.
  5. Confirm the login layout is also good shown on mobile devices. Feel free to use the Google Chrome F12 developer tools for this part

Notes

  • Also add some extra spaces for CS on some places
  • As idea of @dgt41 the login button is full-width. Please let me know how you're thoughts are about that

wilsonge added a commit that referenced this pull request Mar 26, 2015
Update layout login view (redo of #6432)
@wilsonge wilsonge merged commit 9468cdf into joomla:staging Mar 26, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone Mar 26, 2015
@wilsonge
Copy link
Contributor

Merging as original PR was already RTC

@n9iels n9iels deleted the login-update branch March 26, 2015 18:17
@n9iels
Copy link
Contributor Author

n9iels commented Mar 26, 2015

Thanks!

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Apr 1, 2015
@dgrammatiko
Copy link
Contributor

Class btn-block is supposed to equalize the width of the button with the input fields above. Have you tried to clean the browser’s cache?

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants