[fix] for #6601 Banner Manager #6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see #6601 for more info
|
@test works fine for me, the patch solves the issue. Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6602. |
ghost
mentioned this pull request
|
Tested according to instructions. Issue solved! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6602. |
|
Setting RTC - thanks This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6602. |
wilsonge
added a commit
that referenced
this pull request
May 25, 2015
[fix] for #6601 Banner Manager
|
Merged - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #6601 for more info
Hi,
There is a bug in Joomla 3.4x Banner Manager.
When you try to save a Banner Client with the "Use Global" setting for Track Impressions and Track Clicks, it will save the changes as "No" instead of Use Global.
Steps to reproduce bug error:
Go to Banner Manager > Options > save global options as "Yes" for Track Impressions and Track Clicks settings. See attached screenshot 1
Go to Banner Manager > Clients > Edit Client screen and select "Use Global" for Track Impressions and Track Clicks settings and Save. It will change to "No" for those settings. See attached screenshot 2