Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #6770: Pagination limit results are wrong in Smart Search #6771

Merged
merged 1 commit into from
Sep 1, 2015

Conversation

pjmatos
Copy link
Contributor

@pjmatos pjmatos commented Apr 14, 2015

Steps to reproduce the issue

Given the Default List Limit in Global Configuration as 10:

  1. Create at least 11 articles with the same content
  2. Configure a Smart Search module or component
  3. Search in frontend for a word that occurs in all articles

Expected result

In the search page at the bottom it should say "1 to PAGE_LIMIT of TOTAL results"
e.g. with the above steps to reproduce the issue it should say "1 to 10 of 11 results"

Actual result

In the search page at the bottom it says "1 to TOTAL of TOTAL results"
e.g. with the above steps to reproduce the issue it say "1 to 11 of 11 results"

System information (as much as possible)

Additional comments

This happens because there is an error in the template, I will shortly submit a PR

@brianteeman
Copy link
Contributor

Copied description from #6770 we only need one entry on the tracker


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6771.

@coolcat-creations
Copy link
Contributor

Tested successfully.

Mind to:

  1. set global configuration list limit to 10 (i overread this)
  2. publish the plugin "smart search"
  3. index your created pages.

I first didn´t get any results because smart search wasn´t configurated right (plugin and indexing).
Maybe there are some Systemmessages missing?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6771.

@zero-24
Copy link
Contributor

zero-24 commented Jul 27, 2015

RTC based on tests by @designbengel and @mdemop Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6771.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 27, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.4 milestone Aug 25, 2015
Kubik-Rubik added a commit that referenced this pull request Sep 1, 2015
Fix Issue #6770: Pagination limit results are wrong in Smart Search
@Kubik-Rubik Kubik-Rubik merged commit 9c63005 into joomla:staging Sep 1, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 1, 2015
@Kubik-Rubik
Copy link
Member

Thank you @pjmatos! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants