Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System information displays wrong cache path when custom $cache_path entered in configuration.php #6797

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2015

Test:

  • Add a custom path for cache directory in your configuration.php:
public $cache_path = '/absolute/path/to/my/joomla34/mycache';
  • Go to Backend > System > System Information > Directory Permissions
  • You'll see cache and administrator/cache marked as "Cache Directory". Not path entered above that doesn't exist yet and should be marked Unwritable.

cache-before

  • Apply patch:
  • Afterwards you'll see correct path of cache directory like entered in configuration.php.

cache-after

  • If you want to test also column Status (Writable/Unwritable) create custom cache directory now.

@joomdonation
Copy link
Contributor

@test: Success.

@Fedik
Copy link
Member

Fedik commented May 16, 2015

test works good,
but still need to fix the merge conflict

@izharaazmi
Copy link
Contributor

@bertmert When already talking about this, we should consider that the same concept should be applicable for tmp and log paths as well.

@ghost
Copy link
Author

ghost commented May 16, 2015

@Fedik

Merge conflict? I don't understand. Something for me to do here?

@ghost
Copy link
Author

ghost commented May 16, 2015

@izharaazmi
Yes, but
Because there's an open discussion #6579 (without decision yet) I thought about to combine both issues but in the end "I was too scared" ;-)
So, I think, should be another PR.

@zero-24
Copy link
Contributor

zero-24 commented Jun 11, 2015

@bertmert

Merge conflict? I don't understand. Something for me to do here?

Yes. Do you use git via commandline or GUI?

Maybe a rebase can fix it. Else the easiest way to fix it is to open a new PR against staging with a clean branch. As we have 2 successfull test we can set the new or the fixed PR RTC 😄

@zero-24
Copy link
Contributor

zero-24 commented Jun 11, 2015

Closing as we have a new PR thanks @bertmert

@zero-24 zero-24 closed this Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants