Template discover install does not load language files

[mahagr]

When using discover install, path to the template is wrong when loading the language.

Old code pointed to site/templates/{$template} or ADMINISTRATOR/templates/{$template} where it should point to the real directory, either in administration or site.

This pull request will fix the lookup path to point to {$base}/templates/{$template} where base is either JPATH_SITE or JPATH_ADMINISTRATOR.

[mahagr]

To test this:

• Copy beez3 to beez3.bak
• Uninstall beez3 from Extension manager
• Move beez3.bak to beez3
• Make sure beez3 directory is writable by web server
• Discover and install beez3

Before applying the patch, you will see this message:

TPL_BEEZ3_XML_DESCRIPTION

After the patch:

Accessible template for Joomla! Beez, the HTML 4 version.

PS. You can repeat the same with admin template.

[mahagr]

See also: gantry/gantry5#114

[kat05]

this patch works for me, no more missing language strings on discover installations

[MATsxm]

@test

Able to reproduce then #6835 works as expected both for admin & site templates.

Thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6835.}

[Bakual]

@mbabker Can you review? I guess you know the code since you rewrote part of it recently 😄

[phproberto]

@test ok

After applying the patch I tested:

• Install admin template from folder
• Install admin template with discover
• Install admin template from zip
• Install site template from folder
• Install site template with discover
• Install site template from zip

About the discover issue fixed here this was the $source value before applying the patch:

site/templates/mytemplate (wrong)

And the $source value after applying the patch:

/home/roberto/www/jcms3x/templates/mytemplate (right)

I also tested the the $source value was ok for all my install tests.

So 👍 here

[mahagr]

Well, like I said in the pull request comment, the source was wrong also for admin: ADMINISTRATOR/templates/mytemplate.

Fixing $source was the only real change in the patch; rest of it was just reusing the same variable.

[mbabker]

Good to go, consistent with other adapters that have multi-client support.

[mahagr]

Thanks, will now look at my next small improvement for the installer.

[mahagr]

FYI for those who are interested on installer bugs: #6854