Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small UI improvement for mobile #6887

Merged
merged 1 commit into from May 4, 2015
Merged

Small UI improvement for mobile #6887

merged 1 commit into from May 4, 2015

Conversation

dgrammatiko
Copy link
Contributor

Correct the table heading in com_menus - view: menus

The table heading got a hidden class for: Published, Unpublished, Trashed and Linked Modules which breaks the mobile view as the ID is getting in the wrong position. This PR adds some icons and moves the hidden class to a span for the title.

Preview

Right now:
Desktop
screen shot 2015-05-03 at 5 09 20

Mobile
screen shot 2015-05-03 at 5 09 09

After this patch:
Desktop
screen shot 2015-05-03 at 5 07 14

Mobile
screen shot 2015-05-03 at 5 27 15

Testing

Just confirm that the visual changes are correct ????

@zero-24
Copy link
Contributor

zero-24 commented May 3, 2015

@test looks/works great thanks @dgt41


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6887.

@MATsxm
Copy link

MATsxm commented May 4, 2015

@test

works as described.

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6887.

@zero-24
Copy link
Contributor

zero-24 commented May 4, 2015

RTC 😄 Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6887.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 4, 2015
wilsonge added a commit that referenced this pull request May 4, 2015
Small UI improvement for mobile
@wilsonge wilsonge merged commit f33178b into joomla:staging May 4, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone May 4, 2015
@dgrammatiko dgrammatiko deleted the com_menus_mobile branch May 17, 2015 18:45
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants