[related #6080] Fix startOffset issue when useCookie is true

[gunjanpatel]

Thanks @Erftralle for reporting issue in #6080 (comment)

Testing and Reproduce info

Please follow the instructions given in #6080 to reproduce the issue.

You can set startOffset and enable useCookie by setting options shown as below.

$options = array(
    'startOffset' => 3, 
    'useCookie'   => true
);

// Using options
echo JHtml::_('tabs.start', 'pane', $options);

No Backward Compatibility issue

Please also check and confirm that it's not breaking backward compatibility.

[Erftralle]

After applying the patch and using your sample code always Tab4 will be opened.

But what I would expect when using

$options = array(
    'startOffset' => 3, 
    'useCookie'   => true
);

is that Tab4 is shown on initial page load (localStorage or cookie not yet set) and then the last selected tab on all subsequent page loads.

[gunjanpatel]

Thanks @Erftralle for testing.
Yes, is useCookie is false then tabs will not be remembered in browser local storage or cookie.

[Erftralle]

Thanks @Erftralle for testing.

Unfortunately for me it was not a succesfull one :( .

Yes, is useCookie is false then tabs will not be remembered in browser local storage or cookie.

Yes, I know that. Is this answer related to my previous post? If yes, I don't understand you. I was talking about another test case and a different behaviour I would expect.

[gunjanpatel]

Ahh ok. Then I think didn't understand your question clearly. Is another bug found?

As per my opinion Test cases would be like,

• UseCookie => false and startOffset > 0 is given, tab should be selected which is given in startOffset.
• UseCookie => false and startOffset = 0 (default), then first tab should be selected.
• UseCookie => true and startOffset > 0 then given tab index in startOffset should be shown as selected (even if you change tab, it should ignore browser storage or cookie when start offset is given)
• UseCookie => true and startOffset = 0 then it should follow the browser storage or cookie values, mean when you will select tab and refresh the page it will show the tab which was selected before refreshing the page.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.}

[Erftralle]

Seems that we disagree about the expected behaviour of the third test case you mentioned (useCookie => true and startOffset > 0).

Lets see if there are other testers having an opinion to that point.

[slibbe]

I cannot reproduce, as tab3 is opened after the reload (after first selecting tab1 & tab2); no patch applied.

[josien]

Same here, I cannot reproduce the issue (tried in com_search).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.}

[gunjanpatel]

@Erftralle @josien @slibbe can you guys try it again. There was an issue in default behaviour of using storage. By Default storage is not enabled.
Thanks for your tests.

[yvesh]

Okay, we had a big discussion on this at PBF 2 in JUG Munich. It is working as expected, but are you sure on this?

Issues:

1.) IF you want to have the first (0) to be open this is not possible, offset is ignored when you use cookie and offset is zero.

2.) useCookie has no use if start offset is greater then zero.

From a developer perspective this is irritating!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.}

[yvesh]

I have tested this item ✅ successfully on 17541d4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.}

[degobbis]

I have tested this item ✅ successfully on 17541d4

I see it like @yvesh

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.}

[zero-24]

Needs Review so a Maintainer can take the decision on your points. Thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6902.}

[Kubik-Rubik]

Thank you @gunjanpatel! We decided to merge this PR.

[gunjanpatel]

Thanks you all for testing and merging.