Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message on update extension manager #6920

Closed
810 opened this issue May 10, 2015 · 5 comments
Closed

Improve error message on update extension manager #6920

810 opened this issue May 10, 2015 · 5 comments

Comments

@810
Copy link
Contributor

810 commented May 10, 2015

Issue

You get a error when you are updating a beta release "with option: Minimum Stability- stable":
"Invalid extension update"

Should be a better error message like:
"Extension update can't be installed by stability"

How to test

Install Kunena 4.0 beta 2 (https://github.com/Kunena/Kunena-Forum/releases) and find updates.

@brianteeman
Copy link
Contributor

Is that message unique for updates with a minimum stability?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6920.

@810
Copy link
Contributor Author

810 commented May 11, 2015

I think its a global error message. I see no error msg here

if (isset($this->currentUpdate->stability) && ($this->currentUpdate->stability < $this->minimum_stability))

But the next question is also, why I can see the update. I set the option as stable.

@vdespa
Copy link

vdespa commented May 12, 2015

As far as I know (and be aware I might be wrong), the minimum stability feature refers to the process of discovering updates (the findUpdates method).

The error you refer to (with the language string COM_INSTALLER_INVALID_EXTENSION_UPDATE), is actually triggered in the InstallerModelUpdate::install function (which has the comment "Handles the actual update installation.").


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6920.

@brianteeman
Copy link
Contributor

Rather than change the language string (which I dont think we can as it is generic) isnt it better to resolve

But the next question is also, why I can see the update. I set the option as stable.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6920.

@brianteeman
Copy link
Contributor

Hi you created this issue sometime ago but have not provided any code for people to evaluate. As no one else has shown any interest in providing the code and you have not then I am closing this issue at this time. If code is provided (a pull request) it can always be re-examined.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants