-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC Batch modals comply with the new layout #7000
Conversation
Template Isis Success with current Firefox, IE11, current Chrome. and com_banners. Template Hathor: Error 500 Layout default_batch not found. |
@test Tested successfully with both administrator templates. Batch feature still works properly! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7000. |
#7000 Tested successfully with both administrator templates. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7000. |
@test OK (both admin templates) @dgt41 |
@smz Sergio, if you test it, then please mark your result in the issue tracker as well (not only in a comment at GitHub). @dgt41 Thank you for your contribution. I will merge it! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7000. |
@Kubik-Rubik ... oops, forgot about it, sorry! |
@smz Sergio, no problem at all, just a small reminder! :-) |
@Kubik-Rubik Victor, honestly I'd removed those |
... but they do no harm: just ignored. |
OK! |
... or @dgt41 could incorporate that in #7003. I stand-by waiting for @dgt41... |
@smz @Kubik-Rubik will do it in #7003, thanks! |
Batch modals are hardcoded. This is a proposal to make them more flexible/overridable. Right now it’s only for banners, but, if this gets some attention I will make it site wide.
So what’s in it?
Well batch modals have a
tmpl/default_batch.php
file that holds all the html code for the modal.But since @smz and @phproberto made some nice changes in the bootstrap modal everything is more modular and everything is controlled from the respected layouts e.g. body, footer.
So this PR tries to break the hardcoded html code to 2 files
tmpl/default_batch_body.php
andtmpl/default_batch_footer.php
Now we have more control over the output (read this as getting ready for bs3)