Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register to Read More link. Avoid wrong redirects after login when SEF off.. #7015

Closed
wants to merge 7 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2015

@houbahoubi found out while testing PR #6864 that Register to Read More links are always incorrectly redirected to Home page (Home menu item) after login (#6864 (comment)) IF SEF IS NOT ENABLED..
@Kubik-Rubik provided a solution. (#6864 (comment))

This PR (initiated by @infograf768) is correcting accordingly Register to Read More links of following menu items:

  • Articles > Single Article (to be tested with template Protostar).
  • Articles > Category Blog (to be tested with template Protostar).
  • Articles > Category Blog (to be tested with template Beez3 [uses override]).
  • Articles > Category List (to be tested with template Protostar).
  • Articles > Category List (to be tested with template Beez3 [uses override]).
  • Articles > Featured Articles (to be tested with template Protostar).
  • Articles > Featured Articles (to be tested with template Beez3 [uses override]).

Test instructions. Please see also #6864 (comment) but test with menu items.

  • Menu System > Global Configuration > Site > Search Engine Friendly URLs > NO

Most important to see Register to Read More

  • Articles have Readmore marker in text.
  • Articles Access set to Registered
  • Show Unauthorised Links set to YES
  • You're not logged in

Check that you are redirected to correct menu item after login.

@infograf768
Copy link
Member

At reading code, looks fine here.

@Kubik-Rubik Kubik-Rubik added the RTC This Pull Request is Ready To Commit label May 26, 2015
@Kubik-Rubik
Copy link
Member

Merged. Thank you @bertmert!

@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.4.2 milestone May 26, 2015
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants