Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSSQL - fix install extensions crash #7145

Closed
wants to merge 20 commits into from
Closed

MSSQL - fix install extensions crash #7145

wants to merge 20 commits into from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Jun 9, 2015

Steps to reproduce the issue

try to install an extension for example the com_patchtester or the pkg_weblinks or....

Expected result

extension installed or some error msgs

Actual result

joomla crash
the issue is better described here #5890

System information

Windows 2008 R2 10.50.4033
Apache 2.4.7
PHP 5.5.9
Joomla! 3.4.2-dev

Additional comments

now handle the exception that was unhandled #5890

Installation of a module #5850
Add a new menu item to the Main Menu #4207

@alikon
MSSQL - add some extra check null/not null on sqlsrv driver
7ab00f8 
as proposed @vzenix  in #5850

fix some "NULL NOT NULL" issue on MSSQL driver
like  
Installation of a module  #5850
Add a new menu item to the Main Menu #4207
@alikon alikon mentioned this pull request Jun 9, 2015
Closed
@alikon
travis fix
9017d71 
fix spaces
@alikon
travis fix
3ba9e64 
fix  comment rules
@alikon alikon mentioned this pull request Jun 10, 2015
Closed
@alikon
FIX SQLSRV driver unhandled exception
96cbb46 
as reported @JeremyLC  #5890

now should be handled
@alikon alikon changed the title MSSQL - add some extra check null/not null on sqlsrv driver MSSQL - fix install extensions crash Jun 14, 2015
@alikon
travis fix
43f8f80 
150 char x line
@alikon
travis fix
f3687b7 
Multi-line IF statement not indented correctly; expected  spaces but found 4
@mahagr mahagr mentioned this pull request Jun 15, 2015
Closed
alikon added 10 commits June 18, 2015 09:48
@alikon
removed unneeded code
1883bc7 
removed misplaced code
@alikon
better check place
1f4d452 
now the check is executed always
@alikon
fix custom_data
367817e 
fix
  Cannot insert the value NULL into column 'custom_data', table 'j7145_extensions'; column does not allow nulls.
  removed unneeded alias in the menu update
@alikon
added some check
455ea83 
added check for extensions that add a menu item
@alikon
sanitize parent_id
d26528a 
cast parent_id to int
@alikon
custom_data for files
1509874 
fix
  Cannot insert the value NULL into column 'custom_data', table 'j7145_extensions';
@alikon
fix #4207
be55397 
img check
@alikon
travis fix
1d076bc 
cast need a space
@alikon
travis fix
5c6c991 
whitespace
@alikon
custom_data for package
a83b64c 
add custom_data check for package
@alikon alikon mentioned this pull request Aug 27, 2015
Merged
@wilsonge
Copy link
Contributor

Merge conflicts

@alikon
resolve conflict
1af44a2 
conflict merged
@alikon
resolve conflict
2af766e 
merged conflict
@alikon
resolve conflict
892d987 
resolved
@alikon
resolve conflict
e0bda69 
resolved
@alikon
Copy link
Contributor Author

alikon commented Aug 30, 2015

should be resolved

@waader
Copy link
Contributor

waader commented Aug 31, 2015

As I don´t know how to make a package of the weblinks component from the github repository I tested with com_patchtester. I could reproduce the problem and successfully install the component after applying the patch.

With the patch applied I tested also mysql and postgres. On postgres the installation of com_patchtester went well in the first place but when I invoked patchtester an error showed that the table patchtesters_tests wasn´t installed.

Error 0 SQL=SELECT COUNT(*) FROM "ejx7v_patchtester_pulls" AS "a" LEFT JOIN "ejx7v_patchtester_tests" AS "t" ON t.pull_id = a.pull_id

Doing the same without the patch com_patchtester works, well sort of.

@alikon
Copy link
Contributor Author

alikon commented Sep 1, 2015

@waader i've started with a fresh postgresql install and installed the patchtester without this PR , then i've applyed this PR and then unistalled the patchtester. After i've installed the patchtster without issues so i'm unable to reproduce your issue , what steps have you followed to test this PR on different environment ?
wich version of postgresql ?

@joomlacorner
Copy link
Contributor

Tested with install com_patchtester it's work fine for me.
before this patch it's not work.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7145.

@wilsonge
Copy link
Contributor

wilsonge commented Sep 3, 2015

Can you fix the conflicts please?

@wilsonge
Copy link
Contributor

wilsonge commented Sep 7, 2015

I've merged #7778 as this still has conflicts and I wanted at least a partial fix for 3.4.4. Can we fix up the conflicts in here as this seems to touch a bit more than #7778 did

@alikon alikon mentioned this pull request Sep 8, 2015
Merged
@alikon
Copy link
Contributor Author

alikon commented Sep 8, 2015

@wilsonge reworked to remove conflicts and merge with #7778

@alikon
Copy link
Contributor Author

alikon commented Sep 8, 2015

i'm closing cause of merge #7778,#7832

@alikon alikon closed this Sep 8, 2015
@alikon alikon deleted the patch-32 branch September 8, 2015 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alikon @wilsonge @waader @joomlacorner @joomla-cms-bot