Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken batch-modal layout #7302

Closed
wants to merge 2 commits into from
Closed

Broken batch-modal layout #7302

wants to merge 2 commits into from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jul 1, 2015

@mbabker
Copy link
Contributor

mbabker commented Jul 1, 2015

The corresponding LESS file needs to be updated too please.

@chmst
Copy link
Contributor Author

chmst commented Jul 1, 2015

Thank you @mbabker, I added the change to the modal.less. And thank you @zero-24 - I got lost in the tracker :)

@chmst chmst closed this Jul 1, 2015
@zero-24 zero-24 reopened this Jul 1, 2015
@peterlose
Copy link
Contributor

Agree with the change. It also fixes the inline scroll in different modals.

@infograf768
Copy link
Member

You have to indeed modify modals.less, BUT then run generatecss.php as Protostar is also using modals.less and its css has to be modified thrugh this CLI.

infograf768 added a commit to infograf768/joomla-cms that referenced this pull request Jul 2, 2015
@infograf768 infograf768 mentioned this pull request Jul 2, 2015
@infograf768
Copy link
Member

I did a new PR which corrects this one:
#7318

This one can be closed.

@zero-24 zero-24 closed this Jul 2, 2015
rdeutz added a commit that referenced this pull request Jul 2, 2015
@Jay-Jay-OPL
Copy link

To whom it may concern,

I believe this was the last commit made to the Protostar Template before the public release of: Joomla 3.4.3.

If so, there is a bug found with the navigation menu in responsive "mobile" view when having long sub-menus.

These two threads report and provide screenshots of the current issue:

http://forum.joomla.org/viewtopic.php?f=706&t=891691

http://forum.joomla.org/viewtopic.php?f=706&t=892016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants