Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value is null so it doesn't match to the empty option #7317

Merged
merged 1 commit into from Jul 2, 2015

Conversation

rdeutz
Copy link
Contributor

@rdeutz rdeutz commented Jul 2, 2015

This is a fix for #7309, #7308

Steps to reproduce the issue

Create a new menu item for Smart Search

Expected result

Menu link created

Actual result

Invalid field: Date Filters
Invalid field: Advanced Search
Invalid field: Expand Advanced Search

Testing

Apply patch and follow the instructions above. Menu item should be saved without any errors

Background

The problem here is that the validation get's as value null and this is never part of the options array.

@zero-24
Copy link
Member

zero-24 commented Jul 2, 2015

works. Thanks.

@okonomiyaki3000
Copy link
Contributor

Nice!

@brianteeman
Copy link
Contributor

Observed issue creating contactcategory list and smart search menu items
Applied patch and all good

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7317.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jul 2, 2015
mbabker added a commit that referenced this pull request Jul 2, 2015
value is null so it doesn't match to the empty option
@mbabker mbabker merged commit 69abfd0 into joomla:staging Jul 2, 2015
@rdeutz rdeutz deleted the option-validation-hotfix branch July 7, 2015 15:53
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants