Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination user manager when Search Tools present #7487

Merged
merged 2 commits into from Nov 4, 2015

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jul 21, 2015

Issue

Pagination doesn't work when you select a "0" value in the SearchTools. In the user manager this is for example "Activated" or the state "Enabled". In the Article Manager this would be the state "Disabled" (btw consistency ftw!).
See #7486 for the original issue

Solution

I tried to fix that originally with #7194 but did a stupid mistake. Of course "0" is a valid filter value, but my boolean check would take that as an invalid value.
This PR fixes it by only threating an empty string (nothing selected) as invalid.

Testing

Test that the pagination the managers with Search Tools work with any values. Also test that it still works in Hathor and modal layouts.

Known issue so far
The "Groups" filter in the user manager still acts wrong. I haven't found yet why that is. maybe someone has an idea.

@LaurensGoedel
Copy link

This fixes indeed the state filter.
As described, the group filter isn't working. I'll try to have a look at it later today

@LaurensGoedel
Copy link

Somewhere is the function 'getUserStateFromRequest' called with the wrong key. Key com_users.users.default.filter.group is being called instead of com_users.users.default.filter.group_id.

Thats why the cur_state isn't the same as new_state and that is why the limitstart is set to 0

Haven't found the wrong call yet, someone got a clue where to search?

@Bakual
Copy link
Contributor Author

Bakual commented Jul 21, 2015

@LaurensGoedel That was the hint I needed, thanks! Can you try again?

@LaurensGoedel
Copy link

@Bakual yes, thats it!
i've overlooked that multiple times 😞

Thanks!

@zero-24
Copy link
Member

zero-24 commented Nov 4, 2015

I have tested this item ✅ successfully on d667541

Thanks fixes the issue for me.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7487.

@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Nov 4, 2015
@zero-24
Copy link
Member

zero-24 commented Nov 4, 2015

Together with the test by @LaurensGoedel I'm goint to mark this RTC for 3.5.0. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7487.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 4, 2015
@Kubik-Rubik
Copy link
Member

Thank you @Bakual and testers! Merged.

Kubik-Rubik added a commit that referenced this pull request Nov 4, 2015
Pagination user manager when Search Tools present
@Kubik-Rubik Kubik-Rubik merged commit d8e4926 into joomla:staging Nov 4, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 4, 2015
@Bakual Bakual deleted the FixSmartSearchPagination branch November 4, 2015 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants