Convert IDNA_Convert library to be Composer managed, update to 0.9 #7552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e-mail fields and urls fields. When it is used in a page, it is the punycoded version stored in the db which is used as url link or mailto. but the source will be: |
|
Found a small issue which is not related to this patch when displaying contact profile in front-end. Will try to find where it is done. |
|
See #7585 |
Small code style improvement, removing unnecessary else after a return in an if. /components/com_users/controllers/user.php
This is an adaption of #5469 for the category view.
#### Steps to reproduce the issue Go to the language filter plugin In the backend, go to: Extensions->Plugins->System - Language Filter #### Actual result The selector for the "Cookie Lifetime" (Year/Session) is a radio btn type with: class="btn-group btn-group-yesno" then 'success' (green) for "Year" and 'danger' (red) for "Session" #### Expected result As it is not a kind of yes/no selector and to be consistent, I think we should use a type="list" instead of the type="radio"
Codestyle & Doc Block
Use PHP_INT_MAX for maxLevel all in category view.
Add support for the second argument of JLoader::import() to jimport()
Changing the selector type to avoid inconsistency
Prevent notice with unset timezone while formatting a date
[codestyle] Removed redundant elses
# Conflicts: # libraries/legacy/view/category.php
|
Resubmitting against staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the IDNA_Convert library from a Joomla library extension to being managed via Composer (using https://github.com/phpWhois/idna-convert as the source). It also runs an update to version 0.9 of the library and restores the accidentally deleted test class for our Punycode conversions (only affects the 3.5 branch).
Testing
With the patch applied, things should still work as intended. If you've got strings going through the Punycode library (I'm sure JM can tell us all where this is checked), those should still be processed correctly.