Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules batch modals changes #7648

Merged
merged 2 commits into from
Aug 7, 2015
Merged

Modules batch modals changes #7648

merged 2 commits into from
Aug 7, 2015

Conversation

dgrammatiko
Copy link
Contributor

This is complimentary to #7000 and #7003

What is changed:

  1. modals are properly rendered through the API
  2. overrides have only the actual content (no hard coded structure)
  3. obey to ACL
  4. modal is rendered only if items exist
  5. process button class from primary to success (color change from blue to green)

testing

You need to test the batch functionality for this url: administrator/index.php?option=com_modules&view=modules

@joomla-cms-bot
Copy link

Please add more information to your issue. Without test instructions and/or any description we will close this issue soon. Thanks.
This is an automated message from the J!Tracker Application.

@brianteeman
Copy link
Contributor

When this is merged I will look at clarifying the text etc to remove confusion on what is required


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7648.

@brianteeman
Copy link
Contributor

Module Batch processing still works as intended


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7648.

@zero-24
Copy link
Contributor

zero-24 commented Aug 7, 2015

Batch still works. Thanks --> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7648.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2015
@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.4.4 milestone Aug 7, 2015
@Kubik-Rubik
Copy link
Member

Looks good, thank you @dgt41. I will merge it!

@brianteeman Could you please clarify the text? Thank you!

Kubik-Rubik added a commit that referenced this pull request Aug 7, 2015
@Kubik-Rubik Kubik-Rubik merged commit 2072398 into joomla:staging Aug 7, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 7, 2015
@dgrammatiko dgrammatiko deleted the ____batchModules branch August 14, 2015 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants