Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync frontend en-GB.lib_joomla.ini with changes made in backend. #7791

Closed
wants to merge 3 commits into from

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Aug 31, 2015

The en-GB.lib_joomla.ini in frontend is out of sync with the same file in backend.
until now, they were identical and translators could just copy-paste it.
Thanks to @imanickam to catch that.

This PR copies the content from the backend file to the frontend file.
Main difference is the added strings from #7637:

JLIB_HTML_BATCH_MOVE_QUESTION="Do you want to move the items or make a copy of them?"
JLIB_HTML_BATCH_NO_CATEGORY="- Don't move or copy -"

However there are a lot of punctuation changes which are most likely coming from #5615. From what I see there were some changes in that PR which only were did in one of the two files.
I need input here which changes are correct and which should be reverted and thus be fixed in the backend file. @brianteeman can you look over it?

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 31, 2015
@Bakual
Copy link
Contributor Author

Bakual commented Aug 31, 2015

Updated with corrections by @brianteeman (Thanks!)

@infograf768
Copy link
Member

I suggest to merge this asap and let it know to TTs (mainly the 2 new strings).

@Bakual
Copy link
Contributor Author

Bakual commented Sep 1, 2015

I'll check with @imanickam if he wants them merged now or for 3.4.5.
The new strings are already present in the backend and not used in frontend. So there is no hurry to merge it.

@infograf768
Copy link
Member

@Bakual
Some TTs have only a frontend lib_joomla.ini and therefore it has to be told to them or they will not get the 2 new strings.

@infograf768
Copy link
Member

This is for packs who have only a limited backend inis:
See:

https://docs.joomla.org/J3.x:Making_a_Language_Pack_for_Joomla#The_Site-only_pack

@infograf768
Copy link
Member

forget it, it can wait if judged necessary. as in admin is loaded only the admin file.

@Bakual Bakual closed this in afcfb3c Sep 1, 2015
@Bakual Bakual added this to the Joomla! 3.4.4 milestone Sep 1, 2015
@Bakual
Copy link
Contributor Author

Bakual commented Sep 1, 2015

Merged after chatting with @imanickam

@Bakual Bakual deleted the SyncLibJoomla branch September 1, 2015 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants