Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong behaviour in filter method of JForm class #7806

Merged
merged 1 commit into from
Sep 3, 2015
Merged

Fixes wrong behaviour in filter method of JForm class #7806

merged 1 commit into from
Sep 3, 2015

Conversation

Kubik-Rubik
Copy link
Member

This PR fixes the problem that was introduced in this PR #7381. The mentioned PR produces a major bug (Installation process is not possible any more / Form submitting can lead to data loss, see #7799 (comment)). Additionally this PR restores the default behaviour that if a default value is set in a multiple checkbox, then it should also be taken into account (see #7799 (comment)).

It will also solve problems with the validation process because we do not set an empty array as default value (Issue #7316).

How and what to test

Installation process of version 3.4.4 RC

  1. Download the full package of the RC version (https://github.com/joomla/joomla-cms/releases/tag/3.4.4-rc)
  2. Unzip it locally and do the changes from this PR
  3. Start the installation process and verify that it runs properly

Intro image in frontend editing

  1. Create a new article and assign an intro image
  2. Sign in into the frontend and edit the article (e.g. change title)
  3. After the save the intro image should still be available

@Kubik-Rubik
Copy link
Member Author

Increased priority to "Critical" because the fixed bug is a release blocker.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7806.

@alikon
Copy link
Contributor

alikon commented Sep 3, 2015

followed your "how and what" info's and able to install, able to create and change (from frontend) an intro image to an article, but no fantasy to think at other possible tests to check

@RickR2H
Copy link
Member

RickR2H commented Sep 3, 2015

PR works!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7806.

@Fedik
Copy link
Member

Fedik commented Sep 3, 2015

Intro image works now 😄
thanks 😉

@ghazal
Copy link
Contributor

ghazal commented Sep 3, 2015

Installation bug confirmed.
PR works.

@zero-24
Copy link
Contributor

zero-24 commented Sep 3, 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7806.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 3, 2015
Bakual pushed a commit that referenced this pull request Sep 3, 2015
Fixes wrong behaviour in filter method of JForm class
@Bakual Bakual merged commit abcc0eb into joomla:staging Sep 3, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 3, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.4 milestone Sep 3, 2015
@Kubik-Rubik Kubik-Rubik deleted the jform-filter-fix branch May 10, 2016 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants