Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symbol in Admin #7815 #7816

Merged
merged 2 commits into from
Sep 9, 2015
Merged

Update Symbol in Admin #7815 #7816

merged 2 commits into from
Sep 9, 2015

Conversation

Hils
Copy link
Contributor

@Hils Hils commented Sep 4, 2015

After updating Joomla CMS you will see icomoon arrow-up-2 symbol to the left of Joomla! Update heading. This PR changes that symbol to 'loop' which is more appropriate.

update-symbol

https://docs.joomla.org/J3.x:Joomla_Standard_Icomoon_Fonts

@thiago-takeshi
Copy link

i have tested this issue and it worked and i see the correct image.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7816.

@adriano-paula-ribeiro
Copy link

I tested this and see old image and after apply patch i see new image.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7816.

@javigomez
Copy link
Contributor

I have tested and the two views work, showing the new Icon. I agree that it looks much better than the previous one:

screen shot 2015-09-04 at 21 18 37

screen shot 2015-09-04 at 21 11 25

Good job @Hils, and thanks to @thiago-takeshi and @adriano-paula-ribeiro for your first contribution to Joomla ^_^

This tests were done during the Joomla Bug Squad session lead by @roland-d during the Joomla Day Brasilia 2015.

@wilsonge moving this pull to RTC but not merging. Leaving it to you.

@wilsonge wilsonge added this to the Joomla! 3.4.5 milestone Sep 5, 2015
@wilsonge wilsonge added the RTC This Pull Request is Ready To Commit label Sep 5, 2015
wilsonge added a commit that referenced this pull request Sep 9, 2015
@wilsonge wilsonge merged commit f019a04 into joomla:staging Sep 9, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 9, 2015
@wilsonge
Copy link
Contributor

wilsonge commented Sep 9, 2015

Merged - thanks Hils!

@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants