Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize] Add config for admin choose way for generate image of thumbnail for JImage class #7857

Conversation

ThongTran-Dev
Copy link

Allow admin can choose which way they want when generate thumbnail image of JImage class.

  • Best quality but more speed.
  • Fastest speed but not good quality (pixelated bug).

@Bakual
Copy link
Contributor

Bakual commented Sep 11, 2015

Imho, that should be an extension specific setting and not a global one.

@infograf768
Copy link
Member

If considered, please alpha order new string
+COM_CONFIG_THUMBNAIL_SETTINGS="Image Thumbnail Settings"

@wilsonge
Copy link
Contributor

I agree with @Bakual at best this should be a constructor parameter (add a $options array which makes this easier). Then it's down to the extension to initialise as appropriate. It's definitely NOT something to be set in the application

To be honest I'm not even sure if it should be a function specific parameter (you might want to resize an image in good quality at large resolutions and low quality at smaller, for example)

@Bakual
Copy link
Contributor

Bakual commented Sep 11, 2015

Closing this PR as it will not be merged in this form.
Feel free to propose something in the class itself which can be used by the extensions.

@Bakual Bakual closed this Sep 11, 2015
@javigomez
Copy link
Contributor

I'm not sure witch is the right solution but I have tested this and there is an error in the way JImage generates png thumbnails, ending in pixelated results. And with Thong's way the thumb looks good.

Linking here Roberto's comment redCOMPONENT-COM/redCORE#548 (comment)

@wilsonge
Copy link
Contributor

I agree that this needs fixing. But setting it at the JFactory level is 100% wrong. As I said I think it should be at the function level - but if people want it at the class level like i said I could understand it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants