Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #7986] Problem in searching with space using chosen #7987

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

gunjanpatel
Copy link
Contributor

Steps to reproduce the issue

  • Create a category having space in name. For example: "Events and Forms"
  • Make sure you have more than 10 categories, if not try to copy it.
  • Go to article create/edit page, In category selection try to search "event and "

screen shot 2015-09-30 at 05 00 45

  • Now, close the article edit page and go to article listing page. Select any article and click on batch button from toolbar and try to search "event and " like below and notice it is working.

screen shot 2015-09-30 at 05 04 18

Expected result

It should looks like below in article edit page.
screen shot 2015-09-30 at 05 05 36

System information (as much as possible)

I have tested it in FF41.0 Ubuntu. But I believe it's not dependent on browser or OS.

@javigomez
Copy link
Contributor

The change fixes the issue:

screen shot 2015-09-30 at 13 00 01

@javigomez
Copy link
Contributor

I have tested this item ✅ successfully on deb74fe


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7987.

@Devportobello
Copy link
Contributor

About B/C, you are altering the default value who was false Here

@gunjanpatel
Copy link
Contributor Author

I think it will not, because that is core option this.search_contains = this.options.search_contains || false; and I am setting default option for joomla to set search_contains to true.
I think it is okay to enable search_contains it won't harm any functionality. Instead of that it will fix the bug with search using space in all select boxes.

@zero-24
Copy link
Contributor

zero-24 commented Oct 1, 2015

I have tested this item ✅ successfully on deb74fe


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7987.

@zero-24
Copy link
Contributor

zero-24 commented Oct 1, 2015

Works good here. Thanks @gunjanpatel --> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7987.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 1, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.5 milestone Oct 1, 2015
rdeutz added a commit that referenced this pull request Oct 1, 2015
[fix #7986] Problem in searching with space using chosen
@rdeutz rdeutz merged commit 31c53bc into joomla:staging Oct 1, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 1, 2015
@gunjanpatel gunjanpatel deleted the fix-7986 branch October 4, 2015 06:54
@gunjanpatel
Copy link
Contributor Author

Thank you for testing and merging.

@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants