Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user note edit view for Hathor #8066

Merged
merged 2 commits into from
Oct 24, 2015
Merged

Add user note edit view for Hathor #8066

merged 2 commits into from
Oct 24, 2015

Conversation

n9iels
Copy link
Contributor

@n9iels n9iels commented Oct 11, 2015

This PR solves issue #7836. It will add a template override to the Hathor template for the com_users/note/edit.php

How to test

  1. Set Hathor as default admin template
  2. Go to Users -> User Notes and press the new button
  3. Before applying the patch you will see this:
    687474703a2f2f6973737565732e6a6f6f6d6c612e6f72672f75706c6f6164732f312f64383939326132313762383265303263333535633332383636363065373362612e706e67

After applying the patch:
knipsel

  1. Also confirm the layout is the same for editing an user note

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Oct 11, 2015
@@ -196,6 +196,7 @@ COM_USERS_N_USERS_UNBLOCKED="%s Users enabled."
COM_USERS_N_USERS_UNBLOCKED_0="No User enabled."
COM_USERS_N_USERS_UNBLOCKED_1="User enabled."
COM_USERS_NEW_NOTE="New Note"
COM_USERS_EDIT_NOTE="Edit Note"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you alpha sort that string?

@n9iels
Copy link
Contributor Author

n9iels commented Oct 11, 2015

@zero-24 alpha sort the language file. No idea why that line 317 came up

@KingLouis1
Copy link

I have tested this item ✅ successfully on cb4be35


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8066.

2 similar comments
@KingLouis1
Copy link

I have tested this item ✅ successfully on cb4be35


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8066.

@webberry
Copy link

I have tested this item ✅ successfully on cb4be35


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8066.

@SniperSister
Copy link
Contributor

2 successful tests, setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8066.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 24, 2015
@zero-24 zero-24 modified the milestone: Joomla! 3.4.6 Oct 24, 2015
@Kubik-Rubik
Copy link
Member

Thank you @n9iels! Merged.

Kubik-Rubik added a commit that referenced this pull request Oct 24, 2015
Add user note edit view for Hathor
@Kubik-Rubik Kubik-Rubik merged commit bddf1e1 into joomla:staging Oct 24, 2015
@n9iels n9iels deleted the hathor-user-note branch October 24, 2015 10:53
@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015
@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants