Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency use of Components name and View in Title #8072

Closed
wants to merge 16 commits into from

Conversation

marijkestuivenberg
Copy link
Contributor

This applies to all use of the Components name in the respective views of those components. The template for it would be: components name: view
Example:
In com-content the name is Articles, views can be New, Edit, Options, Categories, Featured. It will show the following titles:
Articles: New
Articles: Edit
Articles: Options
Articles: Categories
Articles: Featured

However there are a number of places where this is not used consistently. The component title is used in singular form instead of its original. Sometimes the view after clicking the button New is named different, where New would be more consistent. There are also places where the Title doesn’t match the Name of the (sub) menu items that leads to the view.

Test instructions

These are the places that should be checked before patch (BP) and after patch (AP):

News Feeds
Click on Option
(BP) News Feed: Options - change to plural (AP) News Feeds: Options

Redirect
On the overview page inconsistency in the title:
(BP) Redirects: Links vs Redirect in sub menu item name (in Topmenu: Components) - change both title and submenu to plural (AP) Redirects
Click Options:
(BP) Redirect: Options - (AP) Redirects: Options

Messaging
Inconsistency on the overview page title compared with the submenu title in components; (BP) Messaging in sub menu & title page Private Messages - (AP) Private Messages on both places
Click on the new button:
(BP) Private Messages: Write - (AP) Private Messages: New
Read a private message (sub sub menu item topmenu Components -> Messaging)
(BP) Private Messages: View - (AP) Private Messages: Read (more consistent with sub menu item Components -> Messaging -> Read Private Messages)
Click on Options:
(BP) Messages: Options - (AP) Private Messages: Options

Menus
Click New:
(BP) Menus: Add - (AP) Menus: New

Web Links
Sub menu name in Components is Weblinks while everywhere else it is called Web Links (BP) Weblinks, (AP) Web Links
Click on New:
(BP) Web Links - (AP) Web Links: New *
Click on Edit:
(BP) - Web Links - (AP) Web Links: Edit *
Click on Options:
(BP) Web Links Manager Options - (AP) Web Links: Options
(*) will need changes in administrator/components/com_weblinks/views/weblink/view.html.php on line 61 change
JToolbarHelper::title(JText::_('COM_WEBLINKS_MANAGER_WEBLINK'), 'link weblinks');

into
JToolbarHelper::title($isNew ? JText::_('COM_WEBLINKS_MANAGER_WEBLINK_NEW') : JText::_('COM_WEBLINKS_MANAGER_WEBLINK_EDIT'), 'link weblinks');

Modules
Click on New and select a random module:
(BP) Modules: Module Type - (AP) Modules: New Module Type *
Module Type is the name of the type of Module that was selected

Select a module to edit:
(BP) Modules: Module Type - (AP) Modules: Edit Module Type *
Module Type is the name of the Module that was selected

Click on Options:
(BP) Module: Options - (AP) Modules: Options

Plugins
Click on Options:
(BP) Plugin: Options - plural (AP) Plugins: Options

Templates
Click Options:
(BP) Template: Options - plural (AP) Templates: Options

Languages
(BP)In the sub menu item of Components it is called Language(s), Opposed to the Title of the overview page which shows Languages - (AP) Languages

Note that there are inconsistencies in all Category views, this issue is taken care of in #8070

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Oct 12, 2015
@brianteeman
Copy link
Contributor

I obviously agree that consistency between components is good. One of the problems is that sometimes the component is referred to as a singular and others a plural. Not just in the text displayed but also in the code. It is com_banners and com_categories but only com_content and com_contact.

Personally I believe there does not need to be a direct connection between the dropdown menu and the title. And if we are going to be correct then it should be Singular-edit not Plural-edit as you are only editing a singular not a plural.
(this is the sort of PR I had hoped to do myself but I was told not to make any more useless language changes so good luck)

@brianteeman
Copy link
Contributor

@marijkestuivenberg this PR fails the travis tests

administrator/components/com_modules/views/module/view.html.php
67 | WARNING | Line exceeds 150 characters; contains 212 characters

If it is ok with you I will bring the topic of this PR up at the next en-GB meeting in 10 days time and if we decide to move forward with it then it might just be easier if we create a new pr


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8072.

@marijkestuivenberg
Copy link
Contributor Author

All fine for me, travis complaints about the limit of characters in a line, so it needs to be on two lines probably. Let me know whenever I can help test

@conconnl
Copy link
Member

@brianteeman and @marijkestuivenberg is this PR discussed and can we start testing it?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8072.

@ghost
Copy link

ghost commented Jan 6, 2017

Asking @marijkestuivenberg @brianteeman if this is for testing, cause 8 Months later.

@jeckodevelopment
Copy link
Member

@marijkestuivenberg and @infograf768 can you please look at this?

@ghost
Copy link

ghost commented Mar 11, 2017

any Thoughts on this PR by Maintainers?

@rdeutz
Copy link
Contributor

rdeutz commented May 24, 2017

closing this one, I think it is in important to use language consistent, I would also go with singular instead of plural so fixing the conflicts seems to me more work than making a new PR

@rdeutz rdeutz closed this May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants