Regression: Multilanguage categories association broken: correcting #7998 #8098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the CS that travis is not happy with? https://travis-ci.org/joomla/joomla-cms/builds/85682364 |
|
@zero-24 |
|
@test: |
|
I have tested this item ✅ successfully on 6c46d9f This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8098. |
|
2 good tests. RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8098. |
|
@zero-24 |
|
This PR has received new commits. CC: @dgt41, @fontanil This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8098. |
|
This PR has received new commits. CC: @dgt41, @fontanil This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8098. |
|
This PR has received new commits. CC: @dgt41, @fontanil This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8098. |
roland-d
added a commit
that referenced
this pull request
Oct 17, 2015
Regression: Multilanguage categories association broken: correcting #7998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry folks...
#7998 has introduced an error when categories are associated.
To test: associate categories.
Create menu items displaying these categories (i.e. a category menu item) in their respective languages
Display the menu item in one of the languages and switch to another language: we get a 404.
Patch and test again.
Test also that the original reason for #7998 still works