Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse the returned text to make sure HTML entities show correctly. #8290

Closed

Conversation

roland-d
Copy link
Contributor

@roland-d roland-d commented Nov 5, 2015

Problem

As shown in the screenshot, HTML entities are not converted because of the AJAX call.
screen shot 2015-11-05 at 20 57 50

Solution

This PR parses the returned string as HTML and then puts it out so it shows as correct text
screen shot 2015-11-05 at 20 50 39

Test

  1. Get a clean copy of the Joomla staging branch or download it here
  2. Go through the installation process in German
  3. After reaching the last page when the installation is complete click on the button Verzeichnis „installation” löschen
  4. You will see the resulting text Das Verzeichnis „installation“ wurde gelöscht!
  5. Setup a clean installation again
  6. Replace the file installation/template/js/installation.js with the file attached here or just replace line 308 as shown in the file change
  7. Go through the installation process in German again
  8. After reaching the last page when the installation is complete click on the button Verzeichnis „installation” löschen
  9. You will see the resulting text Das Verzeichnis „installation” wurde gelöscht!
  10. All is good now.

@blueforce
Copy link

I have tested this item ✅ successfully on d8624d3

works for me,
tested with MAMP on OSX, PHP 5.6.10, Safari, Chrome & FF


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8290.

@Kubik-Rubik
Copy link
Member

Event though I like the change, this specific problem was already fixed some time ago and will not be part of the Joomla! 3.5 language package: #7889

@roland-d
Copy link
Contributor Author

roland-d commented Nov 5, 2015

@Kubik-Rubik It's good to see it is already fixed but why isn't going to be in for 3.5 when this was fixed nearly 3 weeks ago?

@Kubik-Rubik
Copy link
Member

@roland-d Ooops, I meant it will be part of the language package... Sorry! :-)

@roland-d roland-d closed this Nov 5, 2015
@roland-d roland-d deleted the parse-ajax-html-installation branch November 5, 2015 21:05
@zero-24
Copy link
Contributor

zero-24 commented Nov 5, 2015

The sync request is here: joomlagerman/joomla#152

@Bakual
Copy link
Contributor

Bakual commented Nov 5, 2015

@Kubik-Rubik Since it's the installation folder, it will not be part of the language pack. It will be shipped with the core.
But we usually do a single round of installation language files updates before a release. After we froze languages for the installation folder.
So yes, this will be fixed for 3.5.0.

@yvesh
Copy link
Member

yvesh commented Nov 6, 2015

I have tested this item ✅ successfully on d8624d3

Works fine, good work.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8290.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants