Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5.0 Beta] Switch plugin list JHTML grid.sort to searchtools.sort #8361

Merged
merged 3 commits into from
Nov 16, 2015

Conversation

tranduyhung
Copy link
Contributor

Steps to reproduce the issue

In Joomla 3.5.0 beta

  • go to plugin list in back-end
  • sort the table by any column (for example sort by plugin name or by ID)
  • navigate to other places in back-end
  • go back to plugin list

Expected result

Plugin table should remember the previous sort and display the plugins in that ordering.

Actual result

The previous sort is not remembered.

System information (as much as possible)

Joomla 3.5.0 beta.

This pull request switches plugin list's default.php layout file from using the old JHtml::('grid.sort') to the new JHtml::('searchtools.sort'), this also fixes the problem described above.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Nov 9, 2015
@infograf768
Copy link
Member

Please alpha order the new strings and delete the 2 empty lines at the top of the ini file.
Otherwise, works OK here.

@tranduyhung
Copy link
Contributor Author

Thank you @infograf768 for letting me know the problems. I fixed in it in my branch.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 6324cfe


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8361.

@RonakParmar
Copy link

I have tested this patch successfully in Joomla 3.5.0 beta.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8361.

@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Nov 10, 2015
@zero-24
Copy link
Contributor

zero-24 commented Nov 10, 2015

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8361.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 10, 2015
rdeutz added a commit that referenced this pull request Nov 16, 2015
…ools

[3.5.0 Beta] Switch plugin list JHTML grid.sort to searchtools.sort
@rdeutz rdeutz merged commit 648da1e into joomla:staging Nov 16, 2015
@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants