Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2 different JS editors in same page will insert duplicate JS functions #8429

Closed
ggppdk opened this issue Nov 14, 2015 · 2 comments
Closed

Comments

@ggppdk
Copy link
Contributor

ggppdk commented Nov 14, 2015

  • Version: Joomla 3.x
  • How to reproduce:
    add 2 different editors in the same page
    e.g. add tinymce and codemirror

you will get this javascript function to be added twice:

function jInsertEditorText( text, editor )
{
 ...
}
  • Example of problem created:
    if you add codemirror after tinymce, then the XTD editor buttons will not work, because the codemirror's jInsertEditorText will be called (as it was added last)
  • maybe this can be re-evaluted in J4.0 ?
    or is it possilbe to fix this without breaking all XTD button extensions ?
@dgrammatiko
Copy link
Contributor

I cannot imagine a solution for 3.x version that would be B/C and work for every 3pd component/plugin. I think this needs to be reviewed for 4.0...

@brianteeman
Copy link
Contributor

Closed as we have a PR #12561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants