Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch modal too small to show all options #8430

Closed
wants to merge 1 commit into from
Closed

Batch modal too small to show all options #8430

wants to merge 1 commit into from

Conversation

anibalsanchez
Copy link
Contributor

Steps to reproduce the issue

When you click on Batch button, for instance in Menu Manager, it shows the batch dialog with three Select controls. They look fine, but when you click on any of Select controls, items are shown below modal-footer.

In the worst case, the second line of controls options are totally hidden.

Expected result

All Select controls have to work.

Actual result

Not possible to select options.

System information (as much as possible)

J 3.5 Beta

Additional comments

".modal-body {min-height: 450px;}" is a viable workaround (instead of max-height). All options can be selected in Menu Manager, Content Manager or Module Manager. Please, test these three cases.

#### Steps to reproduce the issue

When you click on Batch button, for instance in Menu Manager, it shows the batch dialog with three Select controls. They look fine, but when you click on any of Select controls, items are shown below modal-footer.

In the worst case, the second line of controls options are totally hidden.

#### Expected result

All Select controls have to work.

#### Actual result

Not possible to select options.

#### System information (as much as possible)

J 3.5 Beta

#### Additional comments

".modal-body {min-height: 450px;}" is a viable workaround (instead of max-height). All options can be selected in Menu Manager, Content Manager or Module Manager. Please, test these three cases.
@brianteeman
Copy link
Contributor

Please can you check #8373 which has already been merged - I think that
this has already been solved

On 14 November 2015 at 09:10, Anibal Sanchez notifications@github.com
wrote:

Steps to reproduce the issue

When you click on Batch button, for instance in Menu Manager, it shows the
batch dialog with three Select controls. They look fine, but when you click
on any of Select controls, items are shown below modal-footer.

In the worst case, the second line of controls options are totally hidden.
Expected result

All Select controls have to work.
Actual result

Not possible to select options.
System information (as much as possible)

J 3.5 Beta
Additional comments

".modal-body {min-height: 450px;}" is a viable workaround (instead of
max-height). All options can be selected in Menu Manager, Content Manager

or Module Manager. Please, test these three cases.

You can view, comment on, or merge this pull request online at:

#8430
Commit Summary

  • Batch modal too small to show all options

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#8430.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@anibalsanchez
Copy link
Contributor Author

You are right. #8373 solves the issue and a better way.

This issue can be closed as duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants