Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.0 Beta. Fixes #8422. Hathor. Chosened selcetboxes in categories view #8640

Merged
merged 2 commits into from Jan 6, 2016
Merged

3.5.0 Beta. Fixes #8422. Hathor. Chosened selcetboxes in categories view #8640

merged 2 commits into from Jan 6, 2016

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2015

Joomla 3.5.0 beta

Test:

  • Select Hathor as standard template (Backend)
  • Go to Content > Categories
  • Select boxes are "chosened" in filter bar.
  • OPTIONS side by side instead of vertically listed

hathor-chosen

  • Apply patch and try again.
  • Select also Isis as standard template to check.

@Bakual
Copy link
Contributor

Bakual commented Dec 10, 2015

That means the chose select will be removed for any selects in all templates. I don't see a reason for that just because there is an issue in Hathor.
Why not fix it in Hathor?

@Bakual Bakual closed this Dec 10, 2015
@Bakual Bakual reopened this Dec 10, 2015
@ghost
Copy link
Author

ghost commented Dec 10, 2015

I solved it like in all other views for Hathor that have a batch button.
Remove chosen line from batch files in view because default.php already includes chosen and batch files are subtemplates of default.php.
Then you just have to make an override for default.php in Hathor instead of for all files.
Test it with ISIS and you'll see that the patch is correct.

@waader
Copy link
Contributor

waader commented Dec 10, 2015

I have tested this item ✅ successfully on ac3b5bb

Works also with Isis. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8640.

@Bakual
Copy link
Contributor

Bakual commented Dec 10, 2015

Ah, thanks for the explanation. Makes sense.

@rogerhoen
Copy link

I have tested this item ✅ successfully on ac3b5bb

Hi,
(This is my first Joomla test actually). I tested the issue, could reproduce it. After the patch it worked fine.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8640.

@RonakParmar
Copy link

I have tested this item ✅ successfully on ac3b5bb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8640.

@brianteeman
Copy link
Contributor

Setting RTC - thanks for teting


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8640.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 14, 2015
@rdeutz rdeutz added this to the Joomla! 3.5.0 milestone Jan 6, 2016
rdeutz added a commit that referenced this pull request Jan 6, 2016
3.5.0 Beta. Fixes #8422. Hathor. Chosened selcetboxes in categories view
@rdeutz rdeutz merged commit 596274a into joomla:staging Jan 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants