-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect setting show_noauth with linking title #8827
Conversation
Fixing joomla#8790 When using the teaser there should be a link if so configured.
I have tested all the combinations (authorized links = yes/no, clickable title links = yes/no, and acess rights = registered) and it worked as expected. |
@hakanara Please mark this as an successful test with issues.joomla.org. |
I suggest to modify featured default_item.php to use the layout in order to correct the issue there too. |
@sovainfo please tell me how to do that. I don't know how to do it on this platform. I thought a simple OK message would be enough. Thank you very much for your time. I appreciate that very much. |
You need to go to issues.joomla.org and login with your github credentials. Open the PR and hit the test button. Put your comment in and mark it as a successful test. |
@sovainfo thank yo for the info. I did exactly what you wrote above, step by step. I dont see a test button to hit. (I also searched the page, there is no test button that comes with the search results.) Then I searched github help about "how to test a pull request" or "mark a pull request as a successful test" I did not have any answers. I really would like to help you and want this feature to be published but I don't have that test button. Is it because of my credentials? |
Indeed, point 7 tells you what to do. Please report again when there is no test button. |
I have tested this item ✅ successfully on 002eae6 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827. |
I have tested this item ✅ successfully on 002eae6 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827. |
I had to give authorization to repository or something to get this button. And it took one of my senior developer more than half an hour to understand how the button appears, really. Thank you very much for your help :-) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827. |
Suggest to use a separate PR for fixing this issue for Featured. Agree that Featured and Category Blog are out of sync. Probably requires more research to get them on the same page. |
This should be RTC - silly robots This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827. |
Fixing #8790
When using the teaser there should be a link if so configured.