Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect setting show_noauth with linking title #8827

Merged
merged 1 commit into from
May 3, 2016

Conversation

sovainfo
Copy link
Contributor

@sovainfo sovainfo commented Jan 3, 2016

Fixing #8790

When using the teaser there should be a link if so configured.

Fixing joomla#8790

When using the teaser there should be a link if so configured.
@hakanara
Copy link

hakanara commented Jan 3, 2016

I have tested all the combinations (authorized links = yes/no, clickable title links = yes/no, and acess rights = registered) and it worked as expected.

@sovainfo
Copy link
Contributor Author

sovainfo commented Jan 3, 2016

@hakanara Please mark this as an successful test with issues.joomla.org.

@infograf768
Copy link
Member

I suggest to modify featured default_item.php to use the layout in order to correct the issue there too.

@hakanara
Copy link

hakanara commented Jan 4, 2016

@sovainfo please tell me how to do that. I don't know how to do it on this platform. I thought a simple OK message would be enough. Thank you very much for your time. I appreciate that very much.

@sovainfo
Copy link
Contributor Author

sovainfo commented Jan 4, 2016

You need to go to issues.joomla.org and login with your github credentials. Open the PR and hit the test button. Put your comment in and mark it as a successful test.
In order to get implemented it needs two of those successful tests, I, as creator of the PR, am not allowed/do not count.
Will look into Featured later, thank you @infograf768 for reporting it.

@hakanara
Copy link

hakanara commented Jan 4, 2016

@sovainfo thank yo for the info. I did exactly what you wrote above, step by step. I dont see a test button to hit. (I also searched the page, there is no test button that comes with the search results.) Then I searched github help about "how to test a pull request" or "mark a pull request as a successful test" I did not have any answers. I really would like to help you and want this feature to be published but I don't have that test button. Is it because of my credentials?

@andrepereiradasilva
Copy link
Contributor

@sovainfo
Copy link
Contributor Author

sovainfo commented Jan 4, 2016

Indeed, point 7 tells you what to do. Please report again when there is no test button.

@sakicnet
Copy link
Contributor

sakicnet commented Jan 4, 2016

I have tested this item ✅ successfully on 002eae6

Everything fine.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

@hakanara
Copy link

hakanara commented Jan 4, 2016

I have tested this item ✅ successfully on 002eae6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

@hakanara
Copy link

hakanara commented Jan 4, 2016

I had to give authorization to repository or something to get this button. And it took one of my senior developer more than half an hour to understand how the button appears, really. Thank you very much for your help :-)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

@sovainfo
Copy link
Contributor Author

sovainfo commented Jan 4, 2016

Suggest to use a separate PR for fixing this issue for Featured. Agree that Featured and Category Blog are out of sync. Probably requires more research to get them on the same page.
Don't think applying the change made to the title layout to default_item.php is the right thing to do. Agree with @infograf768 on the solution for Featured, not sure its the only thing out of sync.

@brianteeman
Copy link
Contributor

This should be RTC - silly robots


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8827.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 3, 2016
@brianteeman brianteeman added this to the Joomla! 3.6.0 milestone May 3, 2016
@rdeutz rdeutz merged commit 08ac13b into joomla:staging May 3, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 3, 2016
@sovainfo sovainfo deleted the patch-5 branch May 3, 2016 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants